Your flying high, excited and fun, but before you know it, your in it deep with everyone else.
You ask what makes good diving pics? You caught it. Catching the action, freezing the moment, maybe try to catch the concentration on the face. But otherwise, just like any other art, frame it just right(tough to get in that split second.) Get the lighting right, Just experiment, and go with what looks good to you.